[
https://issues.apache.org/jira/browse/GOSSIP-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315562#comment-15315562
]
ASF GitHub Bot commented on GOSSIP-4:
-------------------------------------
Github user doellerbe commented on a diff in the pull request:
https://github.com/apache/incubator-gossip/pull/2#discussion_r65804464
--- Diff:
src/main/java/org/apache/gossip/manager/random/RandomGossipManager.java ---
@@ -42,7 +43,14 @@ public static ManagerBuilder newBuilder() {
private ManagerBuilder() {}
+ private void checkNotNull(Object arg, String msg) {
--- End diff --
Actually, based on @edwardcapriolo (which I just saw),
[comment](https://issues.apache.org/jira/browse/GOSSIP-4?focusedCommentId=15315546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15315546),
we should keep this, but throw an `IllegalArgumentException`.
> Use builder to create RandomGossipManager
> -----------------------------------------
>
> Key: GOSSIP-4
> URL: https://issues.apache.org/jira/browse/GOSSIP-4
> Project: Gossip
> Issue Type: Improvement
> Reporter: Jaideep Dhok
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
