[
https://issues.apache.org/jira/browse/GOSSIP-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317641#comment-15317641
]
Dorian Ellerbe commented on GOSSIP-4:
-------------------------------------
Maybe this is nit, but for clarity, I think we should make the names of the
"setter" methods verbs. "set", "add", "put", or whatever else makes sense.
Otherwise, it looks good to me.
{code:java}
gossipManager = RandomGossipManager.newBuilder()
.setId(id)
.setCluster(cluster)
.setAddress(ipAddress)
.setPort(port)
.setSettings(settings)
.setGossipMembers(gossipMembers)
.setListener(listener)
.build();
{code}
> Use builder to create RandomGossipManager
> -----------------------------------------
>
> Key: GOSSIP-4
> URL: https://issues.apache.org/jira/browse/GOSSIP-4
> Project: Gossip
> Issue Type: Improvement
> Reporter: Jaideep Dhok
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
