[
https://issues.apache.org/jira/browse/GOSSIP-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110154#comment-16110154
]
ASF GitHub Bot commented on GOSSIP-75:
--------------------------------------
Github user edwardcapriolo commented on a diff in the pull request:
https://github.com/apache/incubator-gossip/pull/62#discussion_r130773208
--- Diff:
gossip-base/src/test/java/org/apache/gossip/lock/vote/MajorityVoteTest.java ---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gossip.lock.vote;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.platform.runner.JUnitPlatform;
+import org.junit.runner.RunWith;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Map;
+
+@RunWith(JUnitPlatform.class)
+public class MajorityVoteTest {
+
+ @Test
+ public void differentCandidateMergeTest(){
+ Map<String, VoteCandidate> voteCandidateMap1 = new HashMap<>();
+ VoteCandidate candidateA = new
VoteCandidate("1","key1",generateVotes(1,2,true,true));
+ voteCandidateMap1.put("1",candidateA);
+ MajorityVote first = new MajorityVote(voteCandidateMap1);
+
+ Map<String, VoteCandidate> voteCandidateMap2 = new HashMap<>();
+ VoteCandidate candidateB = new
VoteCandidate("3","key1",generateVotes(3,4,true,false));
+ voteCandidateMap2.put("3",candidateB);
+ MajorityVote second = new MajorityVote(voteCandidateMap2);
+
+ MajorityVote result = first.merge(second);
+
+
Assert.assertTrue(result.value().get("1").getVotes().get("2").getVoteValue());
+
Assert.assertTrue(!result.value().get("3").getVotes().get("4").getVoteValue());
+
+ }
+
+ @Test
+ public void sameCandidateMergeTest(){
+ Map<String, VoteCandidate> voteCandidateMap1 = new HashMap<>();
+ VoteCandidate candidateA = new
VoteCandidate("1","key1",generateVotes(1,2,true,true));
+ voteCandidateMap1.put("1",candidateA);
+ MajorityVote first = new MajorityVote(voteCandidateMap1);
+
+ Map<String, VoteCandidate> voteCandidateMap2 = new HashMap<>();
+ VoteCandidate candidateB = new
VoteCandidate("1","key1",generateVotes(3,4,true,false));
+ voteCandidateMap2.put("1",candidateB);
+ MajorityVote second = new MajorityVote(voteCandidateMap2);
+
+ MajorityVote result = first.merge(second);
+
--- End diff --
clear up these extra spaces
> Voting interface
> ----------------
>
> Key: GOSSIP-75
> URL: https://issues.apache.org/jira/browse/GOSSIP-75
> Project: Gossip
> Issue Type: New Feature
> Reporter: Edward Capriolo
>
> Gossip has CRDT support. This is an important building block to doing higher
> level things. The next piece is being able to act on an object when we
> receive it. For example lets take the most simple case. I want the cluster to
> vote on something such as "who asked for this lock first". Currently we
> replicate objects lazily through a thread, what we want to do is on reception
> of an object apply some function such that we can modify the object being
> received.
> The way I want to go about this is voting objects can be injected with a type
> like VoteContext
> http://stackoverflow.com/questions/27133161/how-to-pass-constructors-parameters-with-jackson
>
> Users can register Voter implementations. On receiving an object the
> interface allows logic to be run. In the case of a Voting each node appends
> its vote as the object moves around over time you can poll your local copy
> and determine the result of the vote.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
