[ https://issues.apache.org/jira/browse/GOSSIP-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143744#comment-16143744 ]
ASF GitHub Bot commented on GOSSIP-41: -------------------------------------- Github user edwardcapriolo commented on a diff in the pull request: https://github.com/apache/incubator-gossip/pull/68#discussion_r135516918 --- Diff: gossip-itest/src/test/java/org/apache/gossip/PerNodeDataEventTest.java --- @@ -23,45 +23,57 @@ import org.apache.gossip.model.PerNodeDataMessage; import org.junit.Assert; import org.junit.Test; -import org.junit.platform.runner.JUnitPlatform; import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; import java.net.URI; import java.net.URISyntaxException; import java.net.UnknownHostException; -import java.util.ArrayList; -import java.util.List; -import java.util.UUID; +import java.util.*; import java.util.concurrent.Semaphore; import java.util.concurrent.TimeUnit; -@RunWith(JUnitPlatform.class) +@RunWith(Parameterized.class) public class PerNodeDataEventTest extends AbstractIntegrationBase { private String receivedKey = ""; private String receivingNodeId = ""; private Object receivingNodeDataNewValue = ""; private Object receivingNodeDataOldValue = ""; private Semaphore lock = new Semaphore(0); - - + private int base; + private boolean bulkTransfer; + + public PerNodeDataEventTest(int base, boolean bulkTransfer) { + this.base = base; + this.bulkTransfer = bulkTransfer; + } + --- End diff -- Slick. I like this. > Transfer gossip data in bulk > ---------------------------- > > Key: GOSSIP-41 > URL: https://issues.apache.org/jira/browse/GOSSIP-41 > Project: Gossip > Issue Type: Improvement > Reporter: Edward Capriolo > Assignee: Pooya Salehi > > Currently the process that transfers shared data and per node data iterates a > map transmitting a single datum at a time using one way communication. We > could transmit more key values at once by simply saying if keys < 100 > transfer all at once, or by collecting keys and sending in groups of 100. > This would greatly lower chatter communicating data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)