Phil Messenger wrote:
I've opened a new Jira and attached some initial code - see GRADLE-299. I
need to work this into svn trunk, but it's up there for any interested
viewers.
Proper patch/tests/etc should be done sometime this week.
Phil
I had a quick look. It looks good.
I have some comments. Some of them are just ideas of where we could take
this task/plugin after we apply your patch. And if you've already done
these in the proper patch, then apologies.
- I think the output format and output file should be properties of the
task, rather than system properties. The plugin should set them by
convention.
- It would be good to make TaskListTask and ShowDependenciesTask
consistent, as they are pretty much the same kind of task:
- Allow ShowDependenciesTask to optionally write to stdout.
- Add a command line option to execute ShowDependenciesTask, just like
-t executes the TaskListTask. Or modify the -t option.
- Add output format and optional output file to TaskListTask.
- Change the plugin to add TaskListTask to the project as well.
- Should the output be grouped by ivy configuration?
- An html output option would be good too.
- I've made BaseDependencyManager public (but not add it to public
interface), so that we don't need to do the reflection.
- I think we should work DependencyTools into DependencyManager somehow,
as it feels like something generally reusable.
Adam
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
