Adam,
Adam Murdoch-2 wrote: > > I had a quick look. It looks good. > Thanks for the feedback. Some comments below... Adam Murdoch-2 wrote: > > I have some comments. Some of them are just ideas of where we could take > this task/plugin after we apply your patch. And if you've already done > these in the proper patch, then apologies. > > - I think the output format and output file should be properties of the > task, rather than system properties. The plugin should set them by > convention. > I chose system properties here as I often want get a different output format without editing the build script. I might usually want a textual output so I can resolve a broken transitive dependency, but occasionally want graphviz output so I can generate a huge graph to scare my programmers with... If I add a command line option to execute the task, I suppose I can use different switches to control the output. Adam Murdoch-2 wrote: > > - It would be good to make TaskListTask and ShowDependenciesTask > consistent, as they are pretty much the same kind of task: > - Allow ShowDependenciesTask to optionally write to stdout. > - Add a command line option to execute ShowDependenciesTask, just like > -t executes the TaskListTask. Or modify the -t option. > - Add output format and optional output file to TaskListTask. > - Change the plugin to add TaskListTask to the project as well. > Good suggestions. Adam Murdoch-2 wrote: > > - Should the output be grouped by ivy configuration? > Probably. At the moment it just shows the runtime configuration. Adam Murdoch-2 wrote: > > - An html output option would be good too. > Agreed. Adam Murdoch-2 wrote: > > - I've made BaseDependencyManager public (but not add it to public > interface), so that we don't need to do the reflection. > Great! Adam Murdoch-2 wrote: > > - I think we should work DependencyTools into DependencyManager somehow, > as it feels like something generally reusable. > Agreed. I slapped it into a static class for expediencies sake here, but I'll work it into a better shared class. Phil. -- View this message in context: http://www.nabble.com/Getting-a-dependency-tree-tp20230810p20318812.html Sent from the gradle-dev mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
