On Aug 5, 2009, at 11:58 PM, Adam Murdoch wrote:



Steve Appling wrote:


Adam Murdoch wrote:


Steve Appling wrote:


Adam Murdoch wrote:


Steve Appling wrote:
I've been playing with the use of the new build task in my company's projects and in gradle's own build. I found a couple of issues that I would like to discuss:

1) The name 'build' unfortunately collides with Project.getBuild() when used unquoted in a build.gradle. Since I think this task will be referred to frequently, we need to resolve this. I really liked 'build' for the task you would use most often :(. Any better ideas for yet another name? Anyone want to support changing the Project.getBuild() method to something else?

This would make sense. What would we call the method?

It's longer, but we could change the interface to BuildInvocation and the method to getBuildInvocation.


We could call it Gradle or GradleInvocation or GradleInstance, and rename what is currently called Gradle to GradleLauncher or GradleExecuter or GradleInvoker or something like that.

Maybe we should call the task something like 'fullbuild' or 'buildall'?

I like leaving the task name as 'build' and renaming the interface to GradleInvocation. Is it OK for me to do this?


I think we should call the method Project.getGradle(), rather then getGradleInvocation()

I think the property should have a short name. I see the point of calling it gradleInvocation. But I think it is too long considering that it is used usually just as the root (e.g. gradleInvocation.taskGraph.whenReady). The long name of the root makes it harder to read the other stuff.

Initially I did not like Gradle as the property name either. It looks too generic. But when playing around with the current Build interface and its methods it feels OK.

gradle.internalRepository
gradle.gradleVersion
gradle.taskGraph

I wouldn't mind a name which is more expressive that this is an instance of a particular build. But I can't think of such a name at the moment. So for me the 'gradle' is OK.

- Hans

--
Hans Dockter
Gradle Project Manager
http://www.gradle.org


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to