Hi Hans,
your refactoring looks good!
My changes are in my github clone repository
http://github.com/jonnybbb/IDEA_Project_Generation
http://github.com/jonnybbb/IDEA_Project_Generation/blob/master/buildSrc/src/main/groovy/com/automatedlogic/gradle/plugin/idea/JavaModuleGenerationStrategy.groovy


@John: Sorry, for getting rid of the ClosureHolder, but we simple could
not see the usage .... But for sure if you/we need to customize the
generated xml we should introduce this kind of functionality back again.

Since i depend on the gradle test api for my tests i have not checked
them in yet. But i will take care of them, to find the way back to the
plugin. Hans can you point me to the ProjectTestHelper you mentioned?

Looking forward to let the plugin grow.

Johannes
 

On Tue, 2010-05-25 at 18:13 +0200, Hans Dockter wrote:
> Hi,
> 
> 
> I have created a repository under Gradle at Github for the IntelliJ
> Gradle plugin: http://github.com/gradle/gradle-intellij-plugin
> 
> 
> The base for this plugin is the work of John Murph with additions by
> Johannes Buehler and Hamlet D'Arcy. I have refactored the sources in
> regard to how the plugin is used and configured.
> 
> 
> @John, @Johannes: I have added you as collaborators to this
> repository.
> 
> 
> - There is now an IdeaModule and an IdeaProject task. The IdeaPlugin
> generates an IdeaProject task if the project is the root project. A
> module task is created for any project the plugin is applied to. The
> plugin also configures those two task instances with default values.
> People can always add additional IdeaModule/Project tasks if they
> want.
> 
> 
> Some things to add:
> - Hooks to customize the generated XML.
> - @Johannes: In your Github branch I could not find the code you have
> shown me to get the source and javadoc jars. So this still need to be
> added.
> - More parameters for the Project/Module tasks (e.g. wildcard for
> resources)
> 
> 
> - Hans
> 
> 
> --
> Hans Dockter 
> Founder, Gradle
> http://www.gradle.org, http://twitter.com/gradleorg
> CEO, Gradle Inc. - Gradle Training, Support, Consulting
> http://www.gradle.biz




---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to