Begin forwarded message: > Commit: 6f554697377af7b91e3fa83bb548557e7f70c387 > > https://github.com/gradle/gradle/commit/6f554697377af7b91e3fa83bb548557e7f70c387 > Author: Luke Daley <[email protected]> > Date: 2011-11-18 (Fri, 18 Nov 2011) > > Changed paths: > M subprojects/core/src/main/groovy/org/gradle/StartParameter.java > M > subprojects/core/src/main/groovy/org/gradle/api/internal/artifacts/ProjectDependenciesBuildInstruction.java > M > subprojects/core/src/main/groovy/org/gradle/api/internal/resource/Resource.java > M > subprojects/core/src/main/groovy/org/gradle/groovy/scripts/ScriptSource.java > M > subprojects/core/src/main/groovy/org/gradle/initialization/BuildFileProjectSpec.java > M > subprojects/core/src/main/groovy/org/gradle/initialization/ProjectDirectoryProjectSpec.java > M subprojects/core/src/test/groovy/org/gradle/StartParameterTest.groovy > M subprojects/internal-testing/src/main/groovy/org/gradle/util/Matchers.java > > Log Message: > ----------- > Made StartParameter and all of its components Serializable. > > This is somewhat of a breaking change, but it's unlikely that there are any > uses of interfaces like ScriptSource out their in the wild. > > One remaining question is whether or now we should put serialVersionUIDs on > these classes to try and speed up serialisation. We aren't talking about a > lot of time here though. Some very basic tests on my machine showed that > serialising a reasonably sized StartParameter is negligible in terms of time. > > > Compare: https://github.com/gradle/gradle/compare/7d2a048…6f55469
I'm a little nervous about this change, but need to build on it for my next work. If anyone has any objections can they please voice soon. What this is working towards is having the daemon client send the StartParameter over the wire the daemon. It also simplifies things as the daemon (or any other remote build agent) doesn't need to know how to construct a StartParameter. -- Luke Daley Principal Engineer, Gradleware http://gradleware.com --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
