We meet every week via a google meeting. The times alternate each week to encourage attendance from multiple time zones. Each week we will provide a summary here to facilitate historical preservation & further discussion. If you would like to join this meeting, you can do so here: https://meet.google.com/her-tjpt-xmf
branch wildcard protection * see https://lists.apache.org/thread/7qmhlhqttbt3nwm753t80flxo2gmfovq * wildcard support appears to now be possible * will move forward on grails-* apache github repos Groovy 5 PR * PR is progressing (https://github.com/apache/grails-core/pull/15557) * (static traits) https://issues.apache.org/jira/browse/GROOVY-11985 - James D to follow-up * (dynamic from compile static) - g.tagLib issue - Paul to take a look * VariableScopeVisitor NPE - James F to take a look * reproducers created and added to main table for all 6 Hibernate PRs * James D split original PR into separate PRs to make reviews easier - step 1 - https://github.com/apache/grails-core/pull/15654 - step 2 - https://github.com/apache/grails-core/pull/15568 * Walter also has worked more on the O(M+N) scaling issue that was identified (pre-existing in hibernate 5) https://github.com/apache/grails-core/pull/15656 (scaling issue) * To accelerate the merge of this change, we discussed these PRs in detail on the call to understand the path forward. High level topics included: - License discussion on GormCompilerAutoConfiguration, HibernateGormAutoConfiguration, HibernateDatastoreSpringInitializer - agreed to restore license headers - optimistic locking - revert hibernate specific changes to tck and move to hibernate specific test - test report aggregation - adopt the gradle aggregation plugin instead of rolling our own - local.properties - keep and merge into shared properties plugin - root ignored files - move to a scratch/ folder and ignore that folder by default instead - RestoreSystemProperties - revert setupSpec specific properties and move to test (setup) based instead - History of extending hibernate criteria builder - implementation does not allow - assumption was made that the grammar wasn't changeable. Walter to investigate. - A change was made to executeUpdate() so that a map must always be passed to it, we want to revert this solution and explore similar protections that groovy sql provides but for hql. Paul was going to take a look at this one. * In addition to the review, the team reflected on the difficulty of reviewing PRs this large, we created some initial lessons learned: - finding one off issues, create specific PRs instead - when an existing implementation exists, but we are creating a new one, we should copy the existing so the diffs can be seen. - rename with git mv so that files can be tracked historically * There was a general agreement that we should update our skills & contribution documentation for these lessons learned & prevent large review problems going forward TagLib PR * https://github.com/apache/grails-core/pull/15465 * Open issue #1 - https://github.com/apache/grails-core/pull/15465#issuecomment-4415816914 * Open Issue #2 - https://github.com/apache/grails-core/pull/15465#issuecomment-4421908089 Grails Trademarks * ASF counsel report that the transfer has been recorded. The online database should be updated shortly Anthropic Glasswing / Mythos access * James Fredley has submitted request to have grails-core and grails-spring-security scanned on the 8.x branch Board Report due - submitted on 5/8 - request to notify dev mailing list in the future to collect further feedback PR review * https://github.com/apache/grails-core/pull/15649 (dbmigration GroovyChangeLogSpec) fixes 8.0.x - needs looked at and back ported to 7.0.x - appears to have started with groovy 4.0.32 commit on 7.0.x - Mattias going to investigate further * readme updates - https://github.com/apache/grails-core/pull/15619 * verify-branch.s - https://github.com/apache/grails-core/pull/15621 - agreement to close * release-drafter - https://github.com/apache/grails-core/pull/15623 - improvements to release drafter. We discussed the concern of concurrent builds and James F is going to follow-up on the PR * build-only dependencies - https://github.com/apache/grails-core/pull/15652 - mentioned the problem of build only dependencies. No conclusion at this time. 7.2.x Release Date * decided to let this cook for some period in case more changes come in spring security test refactor - https://github.com/apache/grails-spring-security/pull/1222 - likely fixes the hangs, we should consider merging spring security & associated dependencies into core mono repo
