Hi Chiristian,
Thank you for your detailed suggestions.

> in Writer::Impl_writePolyPolygon you use the method parameter rPolyPoly.
> You should not do it as it is not clipped. You should only use aPolyPoly
> as it contains the already clipped polygon. Else you loose the clipping.
> The following code in Impl_writePolyPolygon seems to be wrong by using
> both aPolyPoly and aPolyPolgon which was created with unclipped
> rPolyPoly. This needs a rework.

I used to only use aPolyPoly, but I find that the same aPolypoly cannot be 
compared to the the same when they are minused the minPoint.
But if I use rPolyPoly, the same rPolyPoly is the same after they are minused 
the minPoint. I don't know why.

> Also I would love to see that the minimum point is stored inside the
> maShapeIds. The usage of the maIdMinPointMap here seems overly complex.
> It would be much simpier to store the minimum point inside the
> sequential maShapeIds vector.

The Id in maShapedIds vector is not repeatedly, but every Id may match to 
several different minPoints, so how to store them in the vector?

> In swfwriter.hxx please remove the "using namespace" lines. The
> using clause is not to be used in headers. In this special case
> it is not a big problem but it may later lead to confusions. So
> please never ever put a using clause inside a header file.

I find if I remove 
using namespace basegfx;
using namespace ::basegfx::tools;
There leads to some errors as I use define the "getMinPoint" and use the 
"B2DPoint" "getRange()""getMinimum()"


Fang Yaqiong [EMAIL PROTECTED]
2007-08-10
Regards&Thanks!
Tel:010-5802-2828 Ext.693
Beijing Redflag CH2000 Software Co., Ltd.

Reply via email to