Hi Fang Fang Yaqiong wrote: > Hi Christian, > Thank you for your detailed suggestions. > > >> in Writer::Impl_writePolyPolygon you use the method parameter rPolyPoly. >> You should not do it as it is not clipped. You should only use aPolyPoly >> as it contains the already clipped polygon. Else you loose the clipping. >> The following code in Impl_writePolyPolygon seems to be wrong by using >> both aPolyPoly and aPolyPolgon which was created with unclipped >> rPolyPoly. This needs a rework. >> > > I used to only use aPolyPoly, but I find that the same aPolypoly cannot be > compared to the the same when they are minused the minPoint. > But if I use rPolyPoly, the same rPolyPoly is the same after they are minused > the minPoint. I don't know why. > I'm confused here, why do you want to compare a polypolygon with itself? If it is still needed you can always create a temporary PolyPolygon but please base it on the already clipped APolyPoly.
>> Also I would love to see that the minimum point is stored inside the >> maShapeIds. The usage of the maIdMinPointMap here seems overly complex. >> It would be much simpier to store the minimum point inside the >> sequential maShapeIds vector. >> > > The Id in maShapedIds vector is not repeatedly, but every Id may match to > several different minPoints, so how to store them in the vector? > Sequential. It is a vector not a map so it is ok that the same shape id is used multiple times. As discussed during the meeting. >> In swfwriter.hxx please remove the "using namespace" lines. The >> using clause is not to be used in headers. In this special case >> it is not a big problem but it may later lead to confusions. So >> please never ever put a using clause inside a header file. >> > > I find if I remove > using namespace basegfx; > using namespace ::basegfx::tools; > There leads to some errors as I use define the "getMinPoint" and use the > "B2DPoint" "getRange()""getMinimum()" > Please check the documentation about how to use namespaces in c++. In the header you need to fully qualify the classes with namespaces, f.e. ::basegfx::B2DPoint. You sure can move the using statements from the headers to the cxx files so you don't have to fully qualify those classes there. Regards, Christian -- Sun Microsystems GmbH Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
