Hi,

Thanks for the feedback.

> 1. The version number is not updated for filesystem-fuse module, please see
> "Cargo.toml", it should be "0.8.1-incubating".

Is this a major issue?

> 2. Also I noticed that the release tag is not created from the release
> branch "branch-0.8", it is created from the self-owned branch. We should
> only create release tags from the release branch. So, merge this PR (
> https://github.com/apache/gravitino/pull/6825) first, then create a new RC4
> tag based on that commit hash.

Someone needs to review and merge that PR, I cannot merge my own PRs.

> 3. The release package is tar-ed under Mac using BSD tar, so it will have
> lots of unnecessary hidden files and complaints when untar-ed using GNU tar
> in Linux. I think you should use GNU tar in Mac or do the release work in
> Linux.

Can you point out some of these hidden files? From a quick look, I can see any 
in the source release. 

Note that I used teh same commands that the release scripts used, so I guess 
that’s an issue with them as well?


Kind Regards,
Justin

Reply via email to