I see web module have some licenses in the source package. But I can't see them in the binary package. I unzip gravitino-web-0.8.1-incubating.war. I can't see the licenses. Is it ok?
Saisai Shao <sai.sai.s...@gmail.com> 于2025年4月14日周一 16:35写道： > The previous releases all use a Linux environment to do the release, that's > why we have no GNU tar and untar issue. > > ``` > ➜ gravitino-0.8.1-incubating-src ls -al > total 312 > drwxr-xr-x@ 46 jerryshao staff 1472 Apr 10 14:08 . > drwx------@ 62 jerryshao staff 1984 Apr 14 14:34 .. > -rw-r--r--@ 1 jerryshao staff 163 Apr 9 12:54 ._LICENSE > -rw-r--r--@ 1 jerryshao staff 163 Apr 9 12:54 ._MAINTAINERS.md > -rwxr-xr-x@ 1 jerryshao staff 163 Apr 9 12:54 ._bin > -rw-r--r--@ 1 jerryshao staff 163 Apr 10 14:04 ._build.gradle.kts > -rw-r--r--@ 1 jerryshao staff 163 Apr 9 12:57 ._gradle.properties > -rw-r--r--@ 1 jerryshao staff 163 Apr 9 12:54 ._settings.gradle.kts > drwxr-xr-x@ 6 jerryshao staff 192 Apr 14 14:34 .gradle > -rw-r--r--@ 1 jerryshao staff 6416 Apr 9 12:54 CODE_OF_CONDUCT.md > -rw-r--r--@ 1 jerryshao staff 10821 Apr 9 12:54 CONTRIBUTING.md > -rw-r--r--@ 1 jerryshao staff 532 Apr 9 12:54 DISCLAIMER.txt > -rw-r--r--@ 1 jerryshao staff 1080 Apr 9 12:54 GOVERNANCE.md > -rw-r--r--@ 1 jerryshao staff 18245 Apr 9 12:54 LICENSE > -rw-r--r--@ 1 jerryshao staff 7273 Apr 9 12:54 MAINTAINERS.md > -rw-r--r--@ 1 jerryshao staff 938 Apr 9 12:54 NOTICE > -rw-r--r--@ 1 jerryshao staff 7580 Apr 9 12:54 README.md > -rw-r--r--@ 1 jerryshao staff 2869 Apr 9 12:54 ROADMAP.md > -rw-r--r--@ 1 jerryshao staff 1107 Apr 9 12:54 SECURITY.md > ``` > > Justin Mclean <jus...@classsoftware.com> 于2025年4月14日周一 16:10写道： > > > Hi, > > > > Thanks for the feedback. > > > > > 1. The version number is not updated for filesystem-fuse module, please > > see > > > "Cargo.toml", it should be "0.8.1-incubating". > > > > Is this a major issue? > > > > > 2. Also I noticed that the release tag is not created from the release > > > branch "branch-0.8", it is created from the self-owned branch. We > should > > > only create release tags from the release branch. So, merge this PR ( > > > https://github.com/apache/gravitino/pull/6825) first, then create a > new > > RC4 > > > tag based on that commit hash. > > > > Someone needs to review and merge that PR, I cannot merge my own PRs. > > > > > 3. The release package is tar-ed under Mac using BSD tar, so it will > have > > > lots of unnecessary hidden files and complaints when untar-ed using GNU > > tar > > > in Linux. I think you should use GNU tar in Mac or do the release work > in > > > Linux. > > > > Can you point out some of these hidden files? From a quick look, I can > see > > any in the source release. > > > > Note that I used teh same commands that the release scripts used, so I > > guess that’s an issue with them as well? > > > > > > Kind Regards, > > Justin >
