chemikadze commented on a change in pull request #484: GRIFFIN-232 - add
support pluggable predicates
URL: https://github.com/apache/griffin/pull/484#discussion_r264022312
##########
File path: service/pom.xml
##########
@@ -291,7 +292,7 @@ under the License.
</execution>
</executions>
<configuration>
- <classifier>exec</classifier>
+
<classifier>${spring-boot-maven-plugin.classifier}</classifier>
Review comment:
Let implement it in a way, that library jar is built on every build with its
own classifier ("lib"?), without need to specify classifier explicitly, and
keep exec semantics of default jar. Otherwise we'll have semantics of artifacts
changing within same classifier depending on build settings, which is very
error-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
