chemikadze commented on a change in pull request #484: GRIFFIN-232 - add
support pluggable predicates
URL: https://github.com/apache/griffin/pull/484#discussion_r264060866
##########
File path: service/pom.xml
##########
@@ -280,6 +280,23 @@ under the License.
</dependency>
</dependencies>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
Review comment:
will the resulting artifact have all dependencies inside? let make sure it
does not -- typically "library jar" is meant to have only module's classes,
without deps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
