chemikadze commented on a change in pull request #489: GRIFFIN-240 Return
JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r266699234
##########
File path:
service/src/main/java/org/apache/griffin/core/job/CountDownTriggerListener.java
##########
@@ -0,0 +1,49 @@
+package org.apache.griffin.core.job;
+
+import org.quartz.JobExecutionContext;
+import org.quartz.Trigger;
+import org.quartz.TriggerListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.concurrent.CountDownLatch;
+
+public class CountDownTriggerListener implements TriggerListener {
+ private static final Logger LOGGER = LoggerFactory
+ .getLogger(JobServiceImpl.class);
+ private CountDownLatch latch;
+ private String name;
+
+
+ public CountDownTriggerListener(CountDownLatch latch, String name) {
+ this.latch = latch;
+ this.name = name;
+ }
+
+ @Override
+ public String getName() {
+ return name;
+ }
+
+ @Override
+ public void triggerFired(Trigger trigger, JobExecutionContext context) {
+ LOGGER.info("CountDownTriggerListener triggerFired");
Review comment:
should we add name of trigger or trigger listener here? otherwise, these
info log messages are rather useless in production
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
