chemikadze commented on a change in pull request #489: GRIFFIN-240 Return
JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r266699321
##########
File path: service/src/main/java/org/apache/griffin/core/job/JobController.java
##########
@@ -115,8 +120,19 @@ public JobHealth getHealthInfo() {
}
@RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
- @ResponseStatus(HttpStatus.NO_CONTENT)
- public void triggerJob(@PathVariable("id") Long id) throws
SchedulerException {
- jobService.triggerJobById(id);
+ @ResponseStatus(HttpStatus.OK)
+ public JobInstanceBean triggerJob(@PathVariable("id") Long id,
@RequestBody(required = false) String request) throws SchedulerException {
+ return jobService.triggerJobById(id, extractTimeOut(request));
+ }
+
+ private long extractTimeOut(String request) {
Review comment:
this timeout is rather infra concern, than of particular request, and 99% of
all usages won't care about exact value -- let have it as configuration
property, not a request body parameter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
