guoyuepeng commented on a change in pull request #526: [GRIFFIN-283] Move sink
steps into TransformStep
URL: https://github.com/apache/griffin/pull/526#discussion_r317147333
##########
File path:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/Expr2DQSteps.scala
##########
@@ -32,6 +33,10 @@ trait Expr2DQSteps extends Loggable with Serializable {
def getDQSteps(): Seq[DQStep]
+ implicit def recoredWriteStepToList(writeStep: RecordWriteStep):
List[WriteStep] = writeStep :: Nil
+
+ implicit def metricsWriteStepToList(writeStep: MetricWriteStep):
List[WriteStep] = writeStep :: Nil
Review comment:
make sense to me .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
