guoyuepeng commented on a change in pull request #526: [GRIFFIN-283] Move sink
steps into TransformStep
URL: https://github.com/apache/griffin/pull/526#discussion_r317418254
##########
File path:
measure/src/main/scala/org/apache/griffin/measure/step/transform/DataFrameOpsTransformStep.scala
##########
@@ -19,14 +19,16 @@ under the License.
package org.apache.griffin.measure.step.transform
import org.apache.griffin.measure.context.DQContext
+import org.apache.griffin.measure.step.write.WriteStep
/**
* data frame ops transform step
*/
-case class DataFrameOpsTransformStep(name: String,
+case class DataFrameOpsTransformStep[T <: WriteStep](name: String,
inputDfName: String,
rule: String,
details: Map[String, Any],
+ writeStepOpt: Option[T] = None,
Review comment:
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
