[
https://issues.apache.org/jira/browse/GRIFFIN-305?focusedWorklogId=450428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450428
]
ASF GitHub Bot logged work on GRIFFIN-305:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/20 13:11
Start Date: 24/Jun/20 13:11
Worklog Time Spent: 10m
Work Description: chitralverma commented on a change in pull request #575:
URL: https://github.com/apache/griffin/pull/575#discussion_r444881499
##########
File path: measure/src/main/scala/org/apache/griffin/measure/sink/Sink.scala
##########
@@ -18,30 +18,57 @@
package org.apache.griffin.measure.sink
import org.apache.spark.rdd.RDD
+import org.apache.spark.sql.DataFrame
import org.apache.griffin.measure.Loggable
/**
- * sink metric and record
+ * Base trait for batch and Streaming Sinks.
+ * To implement custom sinks, extend your classes with this trait.
*/
trait Sink extends Loggable with Serializable {
- val metricName: String
+
+ val jobName: String
Review comment:
absolutely, I had the same in mind but I was planning to do it as part
of a separate config refactoring in the near future.
Do you suggest I do this right now or later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 450428)
Time Spent: 50m (was: 40m)
> Standardize Sink Hierarchy
> --------------------------
>
> Key: GRIFFIN-305
> URL: https://issues.apache.org/jira/browse/GRIFFIN-305
> Project: Griffin
> Issue Type: Sub-task
> Reporter: Chitral Verma
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
