[ https://issues.apache.org/jira/browse/GRIFFIN-305?focusedWorklogId=450431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450431 ]
ASF GitHub Bot logged work on GRIFFIN-305: ------------------------------------------ Author: ASF GitHub Bot Created on: 24/Jun/20 13:17 Start Date: 24/Jun/20 13:17 Worklog Time Spent: 10m Work Description: chitralverma commented on pull request #575: URL: https://github.com/apache/griffin/pull/575#issuecomment-648813731 @wankunde the `open` and `close` methods are for future custom sinks implementations, for example, Redis, JDBC etc that do not rely on spark datasource v1/ v2. Such data sources require one-time initialization of connection/ connection pool which can then be serialized to all executor each time the write operation is called. This PR also acts as a basic cleanup for structured streaming sinks which I'm working on. I'm also planning to rewrite HDFSSink as FileBasedSink much like FileBasedDataConnector and include many other sinks. Griffin is going to get really exciting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 450431) Time Spent: 1h (was: 50m) > Standardize Sink Hierarchy > -------------------------- > > Key: GRIFFIN-305 > URL: https://issues.apache.org/jira/browse/GRIFFIN-305 > Project: Griffin > Issue Type: Sub-task > Reporter: Chitral Verma > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)