Github user bhlx3lyx7 commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/389#discussion_r209132142
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -49,14 +45,18 @@ Licensed to the Apache Software Foundation (ASF) under
one
@NotNull
private String dslType;
--- End diff --
I suggest set dslType as enum too, containing "spark-sql", "df-ops" and
"griffin-dsl"---
