Github user bhlx3lyx7 commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/389#discussion_r209132757
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -551,18 +551,19 @@ public String getJobHdfsPersistPath(String jobName,
long timestamp) {
return null;
}
if (jobList.get(0).getType().toLowerCase().equals("batch")) {
- return getPersistPath(ENV_BATCH) + "/" + jobName + "/" +
timestamp + "";
+ return getSinksPath(ENV_BATCH) + "/" + jobName + "/" +
timestamp + "";
}
- return getPersistPath(ENV_STREAMING) + "/" + jobName + "/" +
timestamp + "";
+ return getSinksPath(ENV_STREAMING) + "/" + jobName + "/" +
timestamp + "";
}
- private String getPersistPath(String jsonString) {
+ private String getSinksPath(String jsonString) {
try {
JSONObject obj = new JSONObject(jsonString);
JSONArray persistArray = obj.getJSONArray("persist");
--- End diff --
"persist" should change to "sinks" for the new format of env.json
---
