GitHub user grant-xuexu opened a pull request:
https://github.com/apache/incubator-griffin/pull/395
set the fields in configuration classes private
in configuration case classes, get*** functions are defined to access to
the fields, so for consistency, make the fields private
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grant-xuexu/incubator-griffin configuration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #395
----
commit 6e42392d080d2b3c186a775c1daa792d9dc26cdd
Author: Grant <grant.xuexu@...>
Date: 2018-06-14T02:45:40Z
param json reader test case
commit 0b86a2fee01c2a601e46972281cdb4b2c11c8baf
Author: Grant <grant.xuexu@...>
Date: 2018-06-14T03:03:02Z
add header
commit fbc0c1229950780e47cdcafbb4163e074520e27d
Author: Grant Guo <gguo@...>
Date: 2018-07-18T03:39:27Z
Merge branch 'master' of https://github.com/apache/incubator-griffin
commit bfd96ed84690ffa0b10051051b55e6ce5f71c1a4
Author: Grant <grant.xuexu@...>
Date: 2018-06-14T02:45:40Z
param json reader test case
commit 83327079e7c8990c7c732eac7bcdfaddbcc7a55e
Author: Grant <grant.xuexu@...>
Date: 2018-06-14T03:03:02Z
add header
commit 911eba8ba1cea133c9d95662e86aad73ba9ffe83
Author: Grant-Guo <xuexuguo@...>
Date: 2018-08-15T12:27:43Z
Merge branch 'master' of https://github.com/grant-xuexu/incubator-griffin
commit 824d8eaa12e92981069fba4276a241709a0d3b9b
Author: Grant-Guo <xuexuguo@...>
Date: 2018-08-15T13:19:56Z
set the fields in configuration classes private
----
---
