[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

[chemikadze]

Github user chemikadze commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/435#discussion_r224952112
  
    --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java 
---
    @@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(String str) 
{
             return str.replaceAll(escapeHashTagPattern, hashTag);
         }
     
    +    public static TimeZone getTimeZone(String timezone) {
    +        if (StringUtils.isEmpty(timezone)) {
    +            return TimeZone.getDefault();
    +        }
    +        return TimeZone.getTimeZone(timezone);
    +    }
    +
     }
    --- End diff --
    
    @ahutsunshine Well, it's about time, it's utility function, static makes it 
easier to test. Felt like it belongs here.


---