Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224948342
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
AfterViewChecked {
return false;
}
this.measureid = this.getMeasureId();
- let time = new Date().getTimezoneOffset() / 60;
- let timezone = "GMT" + time + ":00";
+ let time = -(new Date().getTimezoneOffset() / 60);
--- End diff --
I have little concern about this.
1. if we want to get the timezone based on current time in browser, we need
to extract and rename the function as gettimezoneBasedonTime
2. why client want to control the schedule timezone, the timezone should be
owned by cluster, client should only need to control schedule time, right?
---
