[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

[guoyuepeng]

Github user guoyuepeng commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/442#discussion_r226866876
  
    --- Diff: 
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
    @@ -81,6 +81,9 @@ Licensed to the Apache Software Foundation (ASF) under one
         @Column(name = "\"out\"")
         private String out;
     
    +    @JsonInclude(JsonInclude.Include.NON_NULL)
    --- End diff --
    
    LGTM 👍 make this cache field explicit, instead of implicit property


---