Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r226871843
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software Foundation (ASF) under one
@Column(name = "\"out\"")
private String out;
+ @JsonInclude(JsonInclude.Include.NON_NULL)
--- End diff --
It look like some other properties are implicit too -- in/out dataframe
name, out, details. So making cache optional felt to be consistent with
everything else.
As far as I undertsand, format-wise it's optional, and keeping it implicit
will make API GET result consistent with body used to create measure object (if
it was not provided, it won't appear in response; if it was provided, it will
appear).
Another thing is if it will be explicit, all measures created before this
field was introduced will have "null" in their body (or we'll need to set it to
false by default, making GET response inconsistent with original content).
Assuming all said above, should it really be explicit field?
---
