2015-04-29 6:50 GMT+02:00 Cédric Champeau <[email protected]>:

> Hi Pascal,
>
> There's no such thing as write access to the mirror, even for closing PRs.
> You have to submit a dummy commit with something recognized by GitHub as a
> message to close a PR. For example "Closes #3". Since such dummy commits
> pollute the history, my suggestion would be that before merging a PR, we do
> an interactive rebase and reword the last commit to include this.
>

I usually merge PRs from github with --no-ff option. So there will always
be a new commit for integration. You can use the commit message of the
merge commit to close the PR.

Benedikt


>
> Hope this helps.
>
> 2015-04-28 23:11 GMT+02:00 Guillaume Laforge <[email protected]>:
>
> > Can one of our kind mentors check if Pascal is well setup? or if there's
> > anything we need to do?
> > Or do we have to bring that to INFRA's attention?
> >
> > Guillaume
> >
> > 2015-04-28 22:38 GMT+02:00 Pascal Schumacher <[email protected]>:
> >
> > > Hello everybody,
> > >
> > > it seems that I do not have write access to
> > > https://github.com/apache/incubator-groovy
> > >
> > > This means I can not close pull requests e.g.:
> > > https://github.com/apache/incubator-groovy/pull/6 using the github
> GUI.
> > :(
> > >
> > > -Pascal
> > >
> > >
> >
> >
> > --
> > Guillaume Laforge
> > Groovy Project Manager
> > Product Ninja & Advocate at Restlet <http://restlet.com>
> >
> > Blog: http://glaforge.appspot.com/
> > Social: @glaforge <http://twitter.com/glaforge> / Google+
> > <https://plus.google.com/u/0/114130972232398734985/posts>
> >
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to