Hi Benedikt,
thanks for the hint. :)
My knowledge of git is very limited, so excuse me if I'm wrong, did you
use the--no-ff to create this commit:
https://github.com/apache/commons-lang/commit/640953167adf3580a2c21077d78e7e7ce84ead03
?
I'm asking, because github shows you as the author of the commit. That
is something I would like to avoid (if possible), because I believe it's
detrimental to the motivation of contributers.
- Pascal
By the way: I really wish I would be able to contribute as much to open
source as you do. Congrats! :)
Am 29.04.2015 um 15:07 schrieb Benedikt Ritter:
2015-04-29 6:50 GMT+02:00 Cédric Champeau <[email protected]>:
Hi Pascal,
There's no such thing as write access to the mirror, even for closing PRs.
You have to submit a dummy commit with something recognized by GitHub as a
message to close a PR. For example "Closes #3". Since such dummy commits
pollute the history, my suggestion would be that before merging a PR, we do
an interactive rebase and reword the last commit to include this.
I usually merge PRs from github with --no-ff option. So there will always
be a new commit for integration. You can use the commit message of the
merge commit to close the PR.
