Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/225#discussion_r161807541
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleAuthenticationProvider.java
---
@@ -260,6 +260,23 @@ public UserContext updateUserContext(UserContext
context,
}
+ @Override
+ public UserContext decorate(UserContext context,
+ AuthenticatedUser authenticatedUser, Credentials credentials)
+ throws GuacamoleException {
+
+ // Simply return the given context, decorating nothing
+ return context;
+
+ }
+
+ @Override
+ public UserContext redecorate(UserContext decorated, UserContext
context,
+ AuthenticatedUser authenticatedUser, Credentials credentials)
+ throws GuacamoleException {
+ return decorate(context, authenticatedUser, credentials);
--- End diff --
Any particular reason in this instance you chose to pass up to the
`decorate()` method rather than just returning the context? In the extension
modules you just `return context`, instead - why the difference?
---
