Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/225#discussion_r162236498
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleAuthenticationProvider.java
---
@@ -260,6 +260,23 @@ public UserContext updateUserContext(UserContext
context,
}
+ @Override
+ public UserContext decorate(UserContext context,
+ AuthenticatedUser authenticatedUser, Credentials credentials)
+ throws GuacamoleException {
+
+ // Simply return the given context, decorating nothing
+ return context;
+
+ }
+
+ @Override
+ public UserContext redecorate(UserContext decorated, UserContext
context,
+ AuthenticatedUser authenticatedUser, Credentials credentials)
+ throws GuacamoleException {
+ return decorate(context, authenticatedUser, credentials);
--- End diff --
Mainly because this is part of the public API and not the internal workings
of an extension. I chose to do things this way so that the class remains
compliant with the expectations of `decorate()` / `redecorate()` if
`decorate()` is overridden while `redecorate()` is not.
---
