Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/274#discussion_r182983461
  
    --- Diff: 
guacamole/src/main/java/org/apache/guacamole/rest/connection/ConnectionResource.java
 ---
    @@ -119,11 +120,13 @@ public ConnectionResource(@Assisted UserContext 
userContext,
         public Map<String, String> getConnectionParameters()
                 throws GuacamoleException {
     
    +        // Pull effective permissions
             User self = userContext.self();
    +        Permissions effective = self.getEffectivePermissions();
    --- End diff --
    
    In the `ConnectionGroupTree` class you did:
    
        Permissions effective = userContext.self().getEffectivePermissions();
    
    eliminating the need for the existence of the `self` object.  Any reason 
not to do the same, here?


---

Reply via email to