Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/274#discussion_r183193049
  
    --- Diff: 
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/User.java ---
    @@ -109,85 +106,33 @@
         List<? extends ActivityRecord> getHistory() throws GuacamoleException;
     
         /**
    -     * Returns all system-level permissions given to this user.
    -     *
    -     * @return
    -     *     A SystemPermissionSet of all system-level permissions granted to
    -     *     this user.
    -     *
    -     * @throws GuacamoleException 
    -     *     If an error occurs while retrieving permissions, or if reading 
all
    -     *     permissions is not allowed.
    -     */
    -    SystemPermissionSet getSystemPermissions() throws GuacamoleException;
    -
    -    /**
    -     * Returns all connection permissions given to this user.
    -     *
    -     * @return
    -     *     An ObjectPermissionSet of all connection permissions granted to 
this
    -     *     user.
    -     *
    -     * @throws GuacamoleException 
    -     *     If an error occurs while retrieving permissions, or if reading 
all
    -     *     permissions is not allowed.
    -     */
    -    ObjectPermissionSet getConnectionPermissions()
    -            throws GuacamoleException;
    -
    -    /**
    -     * Returns all connection group permissions given to this user.
    -     *
    -     * @return
    -     *     An ObjectPermissionSet of all connection group permissions 
granted
    -     *     to this user.
    -     *
    -     * @throws GuacamoleException
    -     *     If an error occurs while retrieving permissions, or if reading 
all
    -     *     permissions is not allowed.
    -     */
    -    ObjectPermissionSet getConnectionGroupPermissions()
    -            throws GuacamoleException;
    -
    -    /**
    -     * Returns all sharing profile permissions given to this user.
    +     * Returns a set of all readable user groups of which this user is a 
member.
    +     * If permission is granted for the current user to modify the 
membership of
    +     * this user, then the returned set will be mutable, and any such
    +     * modifications should be made through changes to the returned set.
          *
          * @return
    -     *     An ObjectPermissionSet of all sharing profile permissions 
granted to
    -     *     this user.
    +     *     The set of all readable user groups of which this user is a 
member.
          *
          * @throws GuacamoleException
    -     *     If an error occurs while retrieving permissions, or if reading 
all
    -     *     permissions is not allowed.
    -     */
    -    ObjectPermissionSet getSharingProfilePermissions()
    -            throws GuacamoleException;
    -
    -    /**
    -     * Returns all permissions given to this user regarding 
currently-active
    -     * connections.
    -     *
    -     * @return
    -     *     An ObjectPermissionSet of all active connection permissions 
granted
    -     *     to this user.
    -     *
    -     * @throws GuacamoleException 
    -     *     If an error occurs while retrieving permissions, or if reading 
all
    -     *     permissions is not allowed.
    +     *     If an error occurs while retrieving the user groups.
          */
    -    ObjectPermissionSet getActiveConnectionPermissions()
    -            throws GuacamoleException;
    +    RelatedObjectSet getUserGroups() throws GuacamoleException;
     
         /**
    -     * Returns all user permissions given to this user.
    +     * Returns a read-only view of all permissions granted to this user. 
The
    +     * exact semantics of what permissions are granted are up to the
    +     * implementation, and the permissions within this view may implied,
    --- End diff --
    
    "may be implied"


---

Reply via email to