Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/299#discussion_r194161639
  
    --- Diff: 
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Credentials.java ---
    @@ -72,6 +72,29 @@
          */
         private transient HttpSession session;
     
    +    /**
    +     * Arbitrary LDAP attributes specified in guacamole.properties
    +     */
    +     private Map<String, String> ldapAttrs;
    +
    +     /**
    +      * Returns the lDAP attributes associated with this set of 
credentials.
    +      * @return The LDAP attributes Map associated with this set of 
credentials,
    +      *         or  null if no LDAP Attributes have been set.
    +      */
    +     public Map<String, String> getLDAPAttributes() {
    +         return ldapAttrs;
    +     }
    +
    +     /**
    +      * Sets the LDAP attributes associated with this set of credentials.
    +      * @param attributes The LDAP attributes to associate with this set of
    +      *                   credentials.
    +      */
    +     public void setLDAPAttributes(Map<String, String> attributes) {
    --- End diff --
    
    > Better perhaps than that would be having AuthenticatedUser implement 
Attributes (as, semantically, it is the user that has these attributes, not 
their credentials).
    
    Ah, yes, that makes more sense.  Sorry, @jaredfrees, I may have steered you 
wrong, here.


---

Reply via email to