Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/299#discussion_r194162564
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
 ---
    @@ -26,12 +26,21 @@
     import org.apache.guacamole.auth.ldap.user.AuthenticatedUser;
     import org.apache.guacamole.auth.ldap.user.UserContext;
     import org.apache.guacamole.GuacamoleException;
    +import org.apache.guacamole.GuacamoleServerException;
     import org.apache.guacamole.auth.ldap.user.UserService;
     import org.apache.guacamole.net.auth.Credentials;
     import org.apache.guacamole.net.auth.credentials.CredentialsInfo;
     import 
org.apache.guacamole.net.auth.credentials.GuacamoleInvalidCredentialsException;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
    +import java.util.HashMap;
    --- End diff --
    
    Generally in the Guacamole code the imports are organized alphabetically, 
so these ones should probably go at the top.


---

Reply via email to