Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/299#discussion_r194865378
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java
---
@@ -344,4 +344,20 @@ public int getOperationTimeout() throws
GuacamoleException {
);
}
+ /**
+ * Returns names for custom LDAP user attributes.
+ *
+ * @return
+ * LDAP user attributes as defined in the guacamole.properties file
+ * as ldap-user-attributes: ''
--- End diff --
This comment just strikes me as a little odd - I would drop the example of
its guacamole.properties definition and just allow that to be documented in the
manual and make this more like the other `@return` tags for other properties.
---
