Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/179#discussion_r209009840
--- Diff: src/guacd/connection.c ---
@@ -70,7 +70,7 @@ static int __write_all(int fd, char* buffer, int length) {
while (length > 0) {
int written = write(fd, buffer, length);
- if (written < 0)
+ if (written < 0 || errno > 0)
--- End diff --
Unless the standards behind `errno` or `write()` define what `errno` will
be after a successful call to `write()`, it is non-portable to make assumptions
about that behavior.
---
