Github user changkun commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/179#discussion_r209011191
  
    --- Diff: src/guacd/connection.c ---
    @@ -70,7 +70,7 @@ static int __write_all(int fd, char* buffer, int length) {
         while (length > 0) {
     
             int written = write(fd, buffer, length);
    -        if (written < 0)
    +        if (written < 0 || errno > 0)
    --- End diff --
    
    How about `if (written < 0 || (written == 0 && errno > 0))`? 
    This condition completely satisfies the man page description.


---

Reply via email to