Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/197#discussion_r228667853
--- Diff: src/terminal/ansi_escape_codes.h ---
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+ #ifndef _GUAC_TERMINAL_H
--- End diff --
1. Why is this `#ifndef` (and the `#include` later) indented by one space?
2. The `_GUAC_TERMINAL_H` name is already used by `terminal.h`. Ignoring
the leading underscore (which is technically incorrect and shouldn't have been
done in `terminal.h`), convention is to convert the name of the header to
uppercase with underscores and add the appropriate namespace.
---
