Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/197#discussion_r228672433
--- Diff: src/terminal/terminal_handlers.c ---
@@ -469,7 +470,7 @@ static int guac_terminal_parse_xterm256_rgb(int argc,
const int* argv,
guac_terminal_color* color) {
/* RGB color palette entries require three arguments */
- if (argc < 3)
--- End diff --
I'm not sure this qualifies as a magic number. The various console codes
definitely do, but 3 here is not a mystical value; it's the number of arguments
required by specifically this sequence. It's worth documenting the format of
the sequence (presumably in the documentation for
`guac_terminal_parse_xterm256_rgb()` and/or the constants which define the
codes that begin that sequence), but I wouldn't think it needs its own constant.
---
