Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/337#discussion_r232139290
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleObjectPermissionSet.java
---
@@ -37,14 +38,77 @@
/**
* The set of all permissions currently granted.
*/
- private Set<ObjectPermission> permissions =
Collections.<ObjectPermission>emptySet();
+ private Set<ObjectPermission> permissions = Collections.emptySet();
/**
- * Creates a new empty SimpleObjectPermissionSet.
+ * Creates a new empty SimpleObjectPermissionSet. If you are not
extending
+ * SimpleObjectPermissionSet and only need an immutable, empty
+ * ObjectPermissionSet, consider using {@link
ObjectPermissionSet#EMPTY_SET}
+ * instead.
*/
public SimpleObjectPermissionSet() {
--- End diff --
So I noticed that the other "Simple" classes seem to define (mostly) empty
read-only classes that require methods to be overridden if you want them to
actually contain data, but this class provides a convenient way of constructing
permission sets, much in the way that `SimpleUser` used to before this PR.
I think a more consistent naming scheme might be beneficial here, as at the
moment, seeing the prefix "SImple" on a class name might give a developer a
false impression about what it does based on previous experience.
---
