Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/337#discussion_r232140865
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleObjectPermissionSet.java
---
@@ -37,14 +38,77 @@
/**
* The set of all permissions currently granted.
*/
- private Set<ObjectPermission> permissions =
Collections.<ObjectPermission>emptySet();
+ private Set<ObjectPermission> permissions = Collections.emptySet();
/**
- * Creates a new empty SimpleObjectPermissionSet.
+ * Creates a new empty SimpleObjectPermissionSet. If you are not
extending
+ * SimpleObjectPermissionSet and only need an immutable, empty
+ * ObjectPermissionSet, consider using {@link
ObjectPermissionSet#EMPTY_SET}
+ * instead.
*/
public SimpleObjectPermissionSet() {
--- End diff --
Yeah, I think you're right that this is not the right place to address
these concerns. I guess as long as we keep moving in the direction of things
being more usable and less confusing this is OK for now.
---
