Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/206#discussion_r245522605
--- Diff: configure.ac ---
@@ -140,6 +140,46 @@ AC_SUBST([COMMON_SSH_INCLUDE],
'-I$(top_srcdir)/src/common-ssh')
AC_SUBST([TERMINAL_LTLIB],
'$(top_builddir)/src/terminal/libguac_terminal.la')
AC_SUBST([TERMINAL_INCLUDE], '-I$(top_srcdir)/src/terminal $(PANGO_CFLAGS)
$(PANGOCAIRO_CFLAGS) $(COMMON_INCLUDE)')
+# pthread stack size
+AC_ARG_WITH(pthread_stack,
+ [AS_HELP_STRING([--with-pthread_stack=<size in bytes>],
+ [explicitly set pthread stack size (8MB is
recommended)])
+ ],pthread_stack_size=$withval
+ AC_DEFINE_UNQUOTED([PTHREAD_STACK_SIZE],
[$pthread_stack_size], [pthread stack size (8MB is recommended)])
+)
+if test "x$ac_cv_lib_pthread_pthread_create" = xyes; then
+ AC_MSG_CHECKING([whether default pthread stack is larger than 8MB])
+ ac_save_libs="$LIBS"
+ LIBS="$LIBS -lpthread"
--- End diff --
What I mean is the failure of this test (whether `pthread_create()` is
defined within libpthread) does not mean `pthread_create()` is not present at
all, nor that the test for `pthread_setattr_default_np()` need not be performed.
This test is essentially a check for whether libpthread needs to be linked
in. If it fails, `pthread_create()`, etc. are still used; POSIX threads are
then simply assumed to be part of libc.
---
