Github user rvs commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/206#discussion_r238507556
  
    --- Diff: src/guacd/daemon.c ---
    @@ -19,6 +19,12 @@
     
     #include "config.h"
     
    +#ifdef PTHREAD_STACK_SIZE
    +#define _GNU_SOURCE 1
    --- End diff --
    
    pthread_setattr_default_np() is available for quite sometime with 
_GNU_SOURCE so I don't think this should be that big of a concern. To make it 
reliable I can add testing for pthread_setattr_default_np to the configure part 
of this patch. Consider this done.
    
    As for the more portable way of doing this -- the only way I know of is to 
add add explicit setting of the stack size right before each call of 
pthread_create. Please let me know if you'd prefer this way of doing it (I can 
see myself wrapping it up in a single function of course).


---

Reply via email to