mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate 
strncpy(), strcat(), etc. to safer libguac implementations.
URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250058281
 
 

 ##########
 File path: src/protocols/rdp/rdp_fs.c
 ##########
 @@ -607,11 +608,10 @@ const char* guac_rdp_fs_read_dir(guac_rdp_fs* fs, int 
file_id) {
 int guac_rdp_fs_normalize_path(const char* path, char* abs_path) {
 
     int i;
-    int path_depth = 0;
+    int path_depth = 1;
 
 Review comment:
   I will check.
   
   I should probably add unit tests for the path manipulation bits, too, 
honestly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to