mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate
strncpy(), strcat(), etc. to safer libguac implementations.
URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250464239
##########
File path: src/protocols/rdp/rdp_fs.c
##########
@@ -607,11 +608,10 @@ const char* guac_rdp_fs_read_dir(guac_rdp_fs* fs, int
file_id) {
int guac_rdp_fs_normalize_path(const char* path, char* abs_path) {
int i;
- int path_depth = 0;
+ int path_depth = 1;
Review comment:
> What did you find?
The additional leading `""` path component is used to ensure the final,
normalized path has a leading backslash following `guac_strljoin()`. I'm adding
documentation to that effect.
> Are you planning on adding more unit tests in this PR?
Yes, to verify that these various normalization functions continue to
function as intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
