mike-jumper commented on a change in pull request #371: GUACAMOLE-717: Handle
LDAPException gracefully when doing a search
URL: https://github.com/apache/guacamole-client/pull/371#discussion_r251162511
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
##########
@@ -220,6 +220,9 @@ public String generateQuery(String filter,
logger.warn("Given a referral, but referrals are
disabled. Error was: {}", e.getMessage());
logger.debug("Got a referral, but configured to not
follow them.", e);
}
+ } catch (LDAPException e) {
+ logger.warn("Failed to process an LDAP search result.");
+ logger.error("Error processing LDAPEntry search result.",e);
Review comment:
Logging an exception in this way will produce a stacktrace in the logs. This
is good, but should only be done at the debug level. The is the origin for the
pattern you see above:
https://github.com/apache/guacamole-client/blob/b3f3b18f0bbd063b4f9ce8ce50329ac3f1e47148/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java#L220-L221
The idea is to not confront users/administrators with stacktraces unless
they truly are interested in debugging information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
