mike-jumper commented on a change in pull request #371: GUACAMOLE-717: Handle
LDAPException gracefully when doing a search
URL: https://github.com/apache/guacamole-client/pull/371#discussion_r251162253
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
##########
@@ -220,6 +220,9 @@ public String generateQuery(String filter,
logger.warn("Given a referral, but referrals are
disabled. Error was: {}", e.getMessage());
logger.debug("Got a referral, but configured to not
follow them.", e);
}
+ } catch (LDAPException e) {
Review comment:
Please don't cuddle the `catch`. We do that for `do`/`while`, but that's
really it. See [the rough
guidelines](http://guacamole.apache.org/guac-style/#braces) and elsewhere:
https://github.com/apache/guacamole-client/blob/b3f3b18f0bbd063b4f9ce8ce50329ac3f1e47148/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java#L208-L213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
